-
Notifications
You must be signed in to change notification settings - Fork 34
added oidc credential forwarding not enabled notification #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
added oidc credential forwarding not enabled notification #391
Conversation
This PR includes documentation updates Updated pages: |
|
||
Suggestions for improvement:: | ||
Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting. | ||
Until enabled, the new remote database alias will fail all access attempts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should clarify that the alias was created successfully. Or maybe that is obvious already? 🤷
Until enabled, the new remote database alias will fail all access attempts. | |
The remote database alias has been created successfully, however all attempts to access it will fail, unless the setting is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea. How about replacing both sentences with something like this:
Until enabled, the new remote database alias will fail all access attempts. | |
Although the remote database alias has been successfully created, you cannot access it until you enable the OIDC credential forwarding by setting the `dbms.security.allow_oidc_credential_forwarding_enabled` to `true`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a suggestion. Is dbms.security.allow_oidc_credential_forwarding_enabled
a new configuration setting? If yes, we need to document it in the Operations manual.
|
||
Suggestions for improvement:: | ||
Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting. | ||
Until enabled, the new remote database alias will fail all access attempts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea. How about replacing both sentences with something like this:
Until enabled, the new remote database alias will fail all access attempts. | |
Although the remote database alias has been successfully created, you cannot access it until you enable the OIDC credential forwarding by setting the `dbms.security.allow_oidc_credential_forwarding_enabled` to `true`. |
Adding notification and status code 01N74 introduced in this PR